Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CameraInfo display #1166

Merged
merged 7 commits into from Mar 25, 2024
Merged

Added CameraInfo display #1166

merged 7 commits into from Mar 25, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 8, 2024

Added CameraInfo display (still a draft)

It brings some new dependencies that probably we should remove (OpenCV) mainly.

This plugin was originally created in this repository https://github.com/jsk-ros-pkg/jsk_visualization but only the ROS 1 version. It will be great to include this plugin here as CameraInfo is a standard message.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Mar 8, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde marked this pull request as ready for review March 14, 2024 14:53
Copy link

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI !

@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 22, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 22, 2024

@ros-pull-request-builder retest this

@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 22, 2024

@ros-pull-request-builder retest this please

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 25, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 4ad1eba into rolling Mar 25, 2024
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/camera_info branch March 25, 2024 20:36
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-jazzy-jalisco-released/37862/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants