Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transformation framework pluggable #346

Merged

Commits on Sep 6, 2018

  1. Configuration menu
    Copy the full SHA
    c6fafad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4eb84e View commit details
    Browse the repository at this point in the history
  3. Improve interface

    Martin-Idel-SI authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    cd60589 View commit details
    Browse the repository at this point in the history
  4. Fix uncrustify

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    bcae120 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    047ce24 View commit details
    Browse the repository at this point in the history
  6. Add frame_transform_tf test

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    10b3e7e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4aca341 View commit details
    Browse the repository at this point in the history
  8. Add visibility control

    Martin-Idel-SI authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    34f8e0c View commit details
    Browse the repository at this point in the history
  9. Fix linters

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    0e7b56c View commit details
    Browse the repository at this point in the history
  10. Delete superfluous code

    Martin-Idel-SI authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    25addf1 View commit details
    Browse the repository at this point in the history
  11. Add missing include to fix build

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    62c765d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a5c1d01 View commit details
    Browse the repository at this point in the history
  13. Refactor frame_transformer_tf_test

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    b38626c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9117995 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7549ed8 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    65f09b6 View commit details
    Browse the repository at this point in the history
  17. Minor refactoring

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    273e836 View commit details
    Browse the repository at this point in the history
  18. Create TransformationManager class

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    d8b6265 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    4c7b2cb View commit details
    Browse the repository at this point in the history
  20. Use TransformationManager class

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    336a5a3 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    af691ab View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    27382ed View commit details
    Browse the repository at this point in the history
  23. Fix tests and mocks

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    83fd0df View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    fb3adde View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    2b0c53f View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    c9f757e View commit details
    Browse the repository at this point in the history
  27. Add unit tests for helper methods

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    2414d6f View commit details
    Browse the repository at this point in the history
  28. Fix Windows warnings

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    17c6683 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    1598a82 View commit details
    Browse the repository at this point in the history
  30. Fix build

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    1c7edc4 View commit details
    Browse the repository at this point in the history
  31. Make FrameTransformer::transform() return a PoseStamped and rename Fr…

    …ameTransformer::lastAvailableTransform()
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    c14682e View commit details
    Browse the repository at this point in the history
  32. Refactor frame_transformer.hpp

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    fb4667d View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    6851143 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    1872a3f View commit details
    Browse the repository at this point in the history
  35. Fix Windows build

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    1750ebb View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    7a0ad04 View commit details
    Browse the repository at this point in the history
  37. Fix uncrustify

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    bb9ddfc View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    38d1064 View commit details
    Browse the repository at this point in the history
  39. Fix Windows warnings

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    f7df47a View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    5eab067 View commit details
    Browse the repository at this point in the history
  41. Cleanup: typos

    anhosi authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    e387c8f View commit details
    Browse the repository at this point in the history
  42. Add TransformationPanel to change transformation plugin at runtime

    Note: The panel is not yet functional and requires the implementation
    of a TransformationManager
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    51409aa View commit details
    Browse the repository at this point in the history
  43. Better naming for init method

    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    b893e13 View commit details
    Browse the repository at this point in the history
  44. Remove unused imports

    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    76b4df7 View commit details
    Browse the repository at this point in the history
  45. Use the TransformationManager in the TransformationPanel

    The TransformationManager is used to retrieve the available plugins
    and to set the transform after selecting it in the GUI
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    1db5bde View commit details
    Browse the repository at this point in the history
  46. Replace the button group by a PropertyTreeWidget with radio buttons

    Now the design fits better with the rest of the panels.
    
    Note: The QTreeView does not allow to place QWidgets into the column,
    thus the self implemented radio button group.
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    9c0a194 View commit details
    Browse the repository at this point in the history
  47. Fix linters

    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    d503f55 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    0797224 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    e9b3f59 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    aa3e244 View commit details
    Browse the repository at this point in the history
  51. Correct namespaces and includes

    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    ada5757 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    2e517bb View commit details
    Browse the repository at this point in the history
  53. Fix linters

    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    774010b View commit details
    Browse the repository at this point in the history
  54. Rename FrameTransformerTF to TFFrameTransformer

    Equivalent to naming scheme for Displays, Panels, etc.
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    0a1efdf View commit details
    Browse the repository at this point in the history
  55. Add DummyTransformer

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    cf2ef06 View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    f1a6c42 View commit details
    Browse the repository at this point in the history
  57. Move transformation_manager.hpp to include folder (to be used in rviz…

    …_default_plugins)
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    780a7a2 View commit details
    Browse the repository at this point in the history
  58. Minor refactoring

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    dad745a View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    a59f47f View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    b2dc7cc View commit details
    Browse the repository at this point in the history
  61. Draw checkbox instead of radio button in RadioButtonProperty

    This prevents rendering issues on macOS, where the radio button would
    be cut off on the bottom.
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    2d9c601 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    06bfd79 View commit details
    Browse the repository at this point in the history
  63. Add tests for DummyTransformer

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    b15f2ae View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    1aa0862 View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    f94b91d View commit details
    Browse the repository at this point in the history
  66. Add PluginInformation struct to rviz_common::Factory

    This allows a factory user to conveniently get all information for one plugin.
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    4cb91d8 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    21b1eb6 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    ecfebe7 View commit details
    Browse the repository at this point in the history
  69. Omit "FrameManager" from TFFrameManager plugin name

    This is equivalent to how e.g. Displays are named
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    ff2bc06 View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    f6025cb View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    814419f View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    ded62bf View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    7a72298 View commit details
    Browse the repository at this point in the history
  74. Refactor factories to work with PluginInfo

    This improves the interaction with factories since all attributes of a
    plugin are immediately available and do not have to be retrieved
    separately.
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    5f81e9f View commit details
    Browse the repository at this point in the history
  75. Change design: from a base common class (OnlyTfCompatibleBaseDisplay)…

    … to a delegate object (TransformerHandlerDelegate)
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    734dd1a View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    4ed214e View commit details
    Browse the repository at this point in the history
  77. Expose a method to check if the current transformer is the correct on…

    …e, to be used in the Display::update() method
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    f3d0eb1 View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    0560e64 View commit details
    Browse the repository at this point in the history
  79. Add tests for TransformerGuard

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    e785cd5 View commit details
    Browse the repository at this point in the history
  80. Configuration menu
    Copy the full SHA
    c16fa40 View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    477da3c View commit details
    Browse the repository at this point in the history
  82. Use TransformerGuard in TFDisplay to make it handle changes of the Fr…

    …ameTransformer type
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    ccf580a View commit details
    Browse the repository at this point in the history
  83. Add config loading and saving to TransformationManager

    Also improves error handling.
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    c45de8f View commit details
    Browse the repository at this point in the history
  84. Configuration menu
    Copy the full SHA
    6208933 View commit details
    Browse the repository at this point in the history
  85. Configuration menu
    Copy the full SHA
    775af65 View commit details
    Browse the repository at this point in the history
  86. Harmonize comment style in frame_transformer.hpp and add TODO for com…

    …mented out method
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    f32c02a View commit details
    Browse the repository at this point in the history
  87. Configuration menu
    Copy the full SHA
    c89dc6b View commit details
    Browse the repository at this point in the history
  88. Configuration menu
    Copy the full SHA
    708e4e3 View commit details
    Browse the repository at this point in the history
  89. Configuration menu
    Copy the full SHA
    b3a6843 View commit details
    Browse the repository at this point in the history
  90. Configuration menu
    Copy the full SHA
    47286bc View commit details
    Browse the repository at this point in the history
  91. Configuration menu
    Copy the full SHA
    93ac8ba View commit details
    Browse the repository at this point in the history
  92. Fix typo

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    a43a12c View commit details
    Browse the repository at this point in the history
  93. Configuration menu
    Copy the full SHA
    949b465 View commit details
    Browse the repository at this point in the history
  94. Fix typo in filename

    q
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    f981147 View commit details
    Browse the repository at this point in the history
  95. Fix pluginlib icon loading crash on missing plugin

    This also fixes the segfault on startup when the transformer to load
    is not available
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    d8cd337 View commit details
    Browse the repository at this point in the history
  96. Configuration menu
    Copy the full SHA
    0c34bdd View commit details
    Browse the repository at this point in the history
  97. Improve TransformerGuard tests

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    d0ac8f8 View commit details
    Browse the repository at this point in the history
  98. Configuration menu
    Copy the full SHA
    9836abc View commit details
    Browse the repository at this point in the history
  99. Configuration menu
    Copy the full SHA
    750be43 View commit details
    Browse the repository at this point in the history
  100. Configuration menu
    Copy the full SHA
    acc241d View commit details
    Browse the repository at this point in the history
  101. Configuration menu
    Copy the full SHA
    01f6a69 View commit details
    Browse the repository at this point in the history
  102. Configuration menu
    Copy the full SHA
    11d7fd3 View commit details
    Browse the repository at this point in the history
  103. Change name of class InternalFrameTransformer to TransformationLibrar…

    …yConnector and of relative getters
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    0ac4d2d View commit details
    Browse the repository at this point in the history
  104. Configuration menu
    Copy the full SHA
    042c6ac View commit details
    Browse the repository at this point in the history
  105. Configuration menu
    Copy the full SHA
    8c6e880 View commit details
    Browse the repository at this point in the history
  106. Minor fixes

    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    a4e14fc View commit details
    Browse the repository at this point in the history
  107. Refactor structs.cpp

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    24fa5e1 View commit details
    Browse the repository at this point in the history
  108. Configuration menu
    Copy the full SHA
    cff13da View commit details
    Browse the repository at this point in the history
  109. Fix points marker behavior on missing transform

    The old routine did not return when transformation fails, which resulted
    in strange visual behavior on Windows
    greimela-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    7050022 View commit details
    Browse the repository at this point in the history
  110. Configuration menu
    Copy the full SHA
    cf4e183 View commit details
    Browse the repository at this point in the history
  111. Refactor TransformerGuard so that it checks the type of the transform…

    …er itself rather than of the connector
    
    -To accomplish this modification the new method getTransformer had to be added to rviz_common::FrameManager
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    59e3dee View commit details
    Browse the repository at this point in the history
  112. Configuration menu
    Copy the full SHA
    154add4 View commit details
    Browse the repository at this point in the history
  113. Update README

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    f36e9fa View commit details
    Browse the repository at this point in the history
  114. Update plugins development guide

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    b2d167a View commit details
    Browse the repository at this point in the history
  115. Fix uncrustify and cpplint

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    82cd6bc View commit details
    Browse the repository at this point in the history
  116. Configuration menu
    Copy the full SHA
    8c3009d View commit details
    Browse the repository at this point in the history
  117. Fix Copyrights

    Martin-Idel-SI authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    c9012c4 View commit details
    Browse the repository at this point in the history
  118. Fix transformer guard test

    Martin-Idel-SI authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    5ae8f13 View commit details
    Browse the repository at this point in the history
  119. Update comment in transformer_guard.hpp and insert TF as default tran…

    …sformer in visual testing config
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    2873d35 View commit details
    Browse the repository at this point in the history
  120. Pass clock to tf2::Buffer contructor

    -Necessary after PR ros2#340
    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    b27d8f6 View commit details
    Browse the repository at this point in the history
  121. Fix tests and uncrustify

    botteroa-si authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    9dfd0a8 View commit details
    Browse the repository at this point in the history
  122. Minor cleanups

    - use "::WeakPtr" convention
    - add missing visibility macro to TransformationManager
    - retain information about tf exceptions when re-throwing
    - fix documentation typo
    anhosi authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    5f7cdf3 View commit details
    Browse the repository at this point in the history
  123. Remove reset button from transformer panel

    - superfluous for small amount of checkboxes
    - Code-Style: reorder functions in transformer panel
    Martin-Idel-SI authored and wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    356f60b View commit details
    Browse the repository at this point in the history
  124. style and whitespace fixes

    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    c389501 View commit details
    Browse the repository at this point in the history
  125. use ++ suffix in loop iterators (cppcheck)

    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    fe7db36 View commit details
    Browse the repository at this point in the history
  126. suppress Ogre warnings when interpreting single header (autocomplete)

    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    17ba6b4 View commit details
    Browse the repository at this point in the history
  127. initialize member variable in constructor

    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    a04e711 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. Implement workaround for missing Qt clicked event

    - Clicking on the transformers view, sometimes the clicked
      event is only sent to the underlying property, not the tree view
    - This results in weird behaviour of the gui
    - With this fix, it can only (rarely) happen that the click does nothing
    Martin-Idel-SI authored and anhosi committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    c986fcc View commit details
    Browse the repository at this point in the history
  2. doc style cleanup

    wjwwood committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    7d644ff View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2018

  1. fixup

    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    8898a67 View commit details
    Browse the repository at this point in the history