Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map display #425

Merged
merged 4 commits into from
Jul 30, 2019
Merged

Fix map display #425

merged 4 commits into from
Jul 30, 2019

Commits on Jul 30, 2019

  1. Improve test for large maps 

    The test fails for the current implementation as the map is too big.
This should not be the case though.
    @Martin-Idel
    Martin-Idel committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    a0a5f7c View commit details
    Browse the repository at this point in the history

  2. Fix swatches to store more data 

    The API of loadRawData takes an Ogre ushort which is
an unsigned short which is guaranteed to be 16 bit.
Hence we should static_cast to a uint16_t instead of a uint8_t.

This will result in the swatch being creatable for much larger
textures
    @Martin-Idel
    Martin-Idel committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    a8208d9 View commit details
    Browse the repository at this point in the history

  3. Minor refactoring of map display 

    - Explain rationale behind maximum swatch split
- Improve const correctness
- Log better error if the map cannot be displayed
- Move method updateDrawnUnder() to place where it
  can actually be executed
    @Martin-Idel
    Martin-Idel committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    4371264 View commit details
    Browse the repository at this point in the history

  4. Improve log messages

    @Martin-Idel
    Martin-Idel committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    f610629 View commit details
    Browse the repository at this point in the history