Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter topics in drop down menu #591

Merged
merged 7 commits into from Aug 18, 2020
Merged

Filter topics in drop down menu #591

merged 7 commits into from Aug 18, 2020

Conversation

audrow
Copy link
Member

@audrow audrow commented Aug 12, 2020 •
edited

Fixes #566; relies on ros2/rosidl#514.

@audrow
Filter topics based
116d29c 
Signed-off-by: Audrow <audrow.nash@gmail.com>
@audrow
Filter topic popup by expected topic type
f28b4b1 
Signed-off-by: Audrow <audrow.nash@gmail.com>
@audrow
Make lookup and replace strings constant + modify error message
1292770 
Signed-off-by: Audrow <audrow.nash@gmail.com>
@audrow
Remove filter topics as unfinished from readme
437b937 
Signed-off-by: Audrow <audrow.nash@gmail.com>
@audrow audrow added the enhancement New feature or request label Aug 12, 2020
@audrow audrow self-assigned this Aug 12, 2020
@audrow
Make linters happy
0a23a6c 
Signed-off-by: Audrow <audrow.nash@gmail.com>
@jacobperron jacobperron self-requested a review August 13, 2020 16:58
@jacobperron jacobperron mentioned this pull request Aug 13, 2020
Merged
@audrow
Use name function to get the message type
a8cfece 
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
jacobperron
jacobperron approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI.

I'll make a rosidl release so that the PR CI job also passes.

rviz_common/include/rviz_common/message_filter_display.hpp Outdated Show resolved Hide resolved
@audrow
Remove string include
2259110 
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@audrow
Copy link
Member Author

audrow commented Aug 17, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow audrow merged commit a598415 into ros2 Aug 18, 2020
audrow added a commit that referenced this pull request Aug 18, 2020
@audrow
Revert "Filter topics in drop down menu (#591)"
2351c76 
This reverts commit a598415.
@jacobperron jacobperron deleted the audrow/filter-topics branch August 18, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@audrow audrow

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[foxy] Dropdown topic menu doesn't filter topics
2 participants
@audrow @jacobperron