Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes policy CMP0135 warning for CMake >= 3.24 (backport #30) #32

Merged
merged 1 commit into from Dec 16, 2022

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 15, 2022

This is an automatic backport of pull request #30 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fixes policy CMP0135 warning for CMake >= 3.24

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
(cherry picked from commit e33de12)
@Crola1702
Copy link
Contributor

Crola1702 commented Dec 15, 2022

We missed backporting this one to humble. I noticed that in this PR: ros2/ros2cli#784 (comment)

Reference build: https://ci.ros2.org/job/ci_windows/18493/

FYI: @Blast545

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@Crola1702
Copy link
Contributor

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@Blast545 Blast545 merged commit 7f2e2f7 into humble Dec 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-30 branch December 16, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants