Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to v1.12.0. #35

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Upgrade to v1.12.0. #35

merged 1 commit into from
Apr 4, 2024

Conversation

marcoag
Copy link
Contributor

@marcoag marcoag commented Apr 3, 2024 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@marcoag
Upgrade to v1.12.0.
b9b6f6e 
Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
@marcoag marcoag mentioned this pull request Apr 3, 2024
Closed
ahcorde
ahcorde approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM spdlog on noble

@clalancette
Copy link
Contributor

The PR looks good, but it looks like CI was run incorrectly. In particular, this is doing --packages-above-and-dependences yaml_cpp_vendor, but instead this should be --packages-above-and-dependencies spdlog_vendor.

@marcoag
Copy link
Contributor Author

marcoag commented Apr 4, 2024

CI has been re-ran, hopefully this time with the corrects values 😁 :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 17a72b5 into rolling Apr 4, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the marcoag/spdlog-v1.12.0 branch April 4, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@ahcorde ahcorde ahcorde approved these changes

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

@cottsay cottsay Awaiting requested review from cottsay cottsay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcoag @clalancette @ahcorde