Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to spdlog 1.9.1 #27

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Update to spdlog 1.9.1 #27

merged 2 commits into from
Sep 26, 2022

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented May 13, 2022 •
edited
Loading

This way we match what is in Ubuntu 22.04

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • Windows Debug Build Status

@clalancette clalancette changed the title This way we match the version in Ubuntu 22.04. Update to spdlog 1.9.1 May 13, 2022
@audrow audrow changed the base branch from master to rolling June 28, 2022 14:25
@quarkytale
Copy link
Contributor

Retriggered Windows CI Build Status

quarkytale
quarkytale approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this got backtracked. Works for me!

@clalancette
Copy link
Contributor Author

Here's a new CI for this since it has been a while:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@quarkytale
Copy link
Contributor

There seems to be a persistent syntax error at C:\ci\ws\install\include\spdlog\fmt\bundled\core.h:536. I'll check on my system again.

@clalancette
Copy link
Contributor Author

There seems to be a persistent syntax error at C:\ci\ws\install\include\spdlog\fmt\bundled\core.h:536. I'll check on my system again.

Good point. I'll see what I can find out about it.

@clalancette
Copy link
Contributor Author

I put a fix in to ignore cppcheck warnings on the bundled library. Here's another CI to check:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@quarkytale
Copy link
Contributor

Retriggered windows CI Build Status

@clalancette
Copy link
Contributor Author

clalancette commented Aug 15, 2022 •
edited
Loading

Retriggered windows CI Build Status

Sigh, there is something else I need to fix, down in the rcl_logging layer. It won't work until then.

@clalancette
This way we match the version in Ubuntu 22.04.
7d8b197 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Exclude cppcheck for this package.
ab0926f 
It doesn't seem to understand the C++ syntax in fmt, which
is bundled with spdlog 1.9.1.  Since that is a 4th party
package, let's just skip it.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

clalancette commented Sep 20, 2022 •
edited
Loading

All right, I've done the necessary updates to rcl_logging, which will have to be merged before this PR. Here's new CI for the both of them:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette mentioned this pull request Sep 20, 2022
Merged
@clalancette
Copy link
Contributor Author

@quarkytale I finally had time to come back to this, and I finally got this to go green on Windows. We'll need the change in ros2/rcl_logging#93 as well, so I'd appreciate if you could review them both.

@clalancette
Copy link
Contributor Author

CI is finally happy with the changes from ros2/rcl_logging#93 . Going ahead and merging. Thanks for the review!

@clalancette clalancette merged commit 5d89e00 into rolling Sep 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the clalancette/update-to-1.9.1 branch September 26, 2022 13:05
@clalancette
Copy link
Contributor Author

I just realized I should have run Windows Debug CI. Here it is:

  • Windows Debug Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quarkytale quarkytale quarkytale approved these changes

Assignees

@quarkytale quarkytale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @quarkytale