-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: reorganize policy API #190
Conversation
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 54.76% 54.92% +0.15%
==========================================
Files 14 15 +1
Lines 577 579 +2
Branches 52 52
==========================================
+ Hits 316 318 +2
Misses 247 247
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
84f7c19
to
acf20e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The Windows spdlog issue is unrelated. Merging. |
This PR continues the reorganization of #188 by extracting the policy API into its own module.
Note that this introduces no behavioral changes, it's just moving code around.