Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission signing should use permissions_ca #204

Merged
merged 1 commit into from
May 1, 2020

Conversation

mikaelarguedas
Copy link
Member

it worked until now because we're currently using the same ca for identity and permission signing and just symlink it.

This refers to the file names explicitly for the case they are not actual different CAs

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #204 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   77.48%   77.52%   +0.03%     
==========================================
  Files          16       16              
  Lines         573      574       +1     
  Branches       53       53              
==========================================
+ Hits          444      445       +1     
  Misses        109      109              
  Partials       20       20              
Flag Coverage Δ
#unittests 77.52% <100.00%> (+0.03%) ⬆️
Impacted Files Coverage Δ
sros2/sros2/api/_key.py 90.27% <100.00%> (+0.13%) ⬆️
sros2/sros2/api/_permission.py 92.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1382be3...546af74. Read the comment docs.

@mikaelarguedas
Copy link
Member Author

nightly failure expected as ros2/ros2cli#501 hasn't made it into a nightly archive yet

@mikaelarguedas mikaelarguedas merged commit 2eb0f71 into ros2:master May 1, 2020
@mikaelarguedas mikaelarguedas deleted the fix_permissions_ca branch May 1, 2020 20:05
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants