Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matching validity dates for cert and permissions #205

Merged
merged 3 commits into from
May 4, 2020

Conversation

mikaelarguedas
Copy link
Member

Bugfix for #186

  • creates a load_cert utility function and refactor the code to use it
  • adds 2 template arguments to the permission stylesheet: not_valid_before and not_valid_after
  • pass the validity timepoints from the identity cert to the permission template

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #205 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   77.52%   77.72%   +0.19%     
==========================================
  Files          16       16              
  Lines         574      579       +5     
  Branches       53       53              
==========================================
+ Hits          445      450       +5     
  Misses        109      109              
  Partials       20       20              
Flag Coverage Δ
#unittests 77.72% <100.00%> (+0.19%) ⬆️
Impacted Files Coverage Δ
sros2/sros2/api/_key.py 90.14% <100.00%> (-0.14%) ⬇️
sros2/sros2/api/_permission.py 93.02% <100.00%> (+0.71%) ⬆️
sros2/sros2/api/_utilities.py 86.48% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb0f71...2a1b84a. Read the comment docs.

@mikaelarguedas
Copy link
Member Author

@ros2/security-reviewers heads-up I'm planning on merging this today, please consider submitting your reviews in the next couple hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants