Switch to target_link_libraries everywhere. (#532)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ros2 · Nov 27, 2023 · c200dd3 · c200dd3
1 parent 2322223
commit c200dd3
Show file tree

Hide file tree

Showing 5 changed files with 57 additions and 81 deletions.
diff --git a/test_cli/CMakeLists.txt b/test_cli/CMakeLists.txt
@@ -33,8 +33,9 @@ if(BUILD_TESTING)
 
   add_executable(initial_params_rclcpp
     test/initial_params.cpp)
-  ament_target_dependencies(initial_params_rclcpp
-    "rclcpp")
+  target_link_libraries(initial_params_rclcpp
+    rclcpp::rclcpp
+  )
 
   ament_add_pytest_test(test_params_yaml
     test/test_params_yaml.py

diff --git a/test_cli_remapping/CMakeLists.txt b/test_cli_remapping/CMakeLists.txt
@@ -34,9 +34,10 @@ if(BUILD_TESTING)
 
   add_executable(name_maker_rclcpp
     test/name_maker.cpp)
-  ament_target_dependencies(name_maker_rclcpp
-    "rclcpp"
-    "test_msgs")
+  target_link_libraries(name_maker_rclcpp
+    rclcpp::rclcpp
+    ${test_msgs_TARGETS}
+  )
 
   add_launch_test(
     test/test_cli_remapping.py

diff --git a/test_communication/CMakeLists.txt b/test_communication/CMakeLists.txt
@@ -125,11 +125,11 @@ if(BUILD_TESTING)
   function(custom_executable target)
     add_executable(${target} ${ARGN})
     rosidl_get_typesupport_target(cpp_typesupport_target "${PROJECT_NAME}" "rosidl_typesupport_cpp")
-    target_link_libraries(${target} "${cpp_typesupport_target}")
-    ament_target_dependencies(${target}
-      "rclcpp"
-      "rclcpp_action"
-      "test_msgs"
+    target_link_libraries(${target}
+      "${cpp_typesupport_target}"
+      rclcpp::rclcpp
+      rclcpp_action::rclcpp_action
+      ${test_msgs_TARGETS}
     )
   endfunction()
 
@@ -143,9 +143,11 @@ if(BUILD_TESTING)
       RMW_IMPLEMENTATION=${rmw_implementation})
     if(TARGET ${target}${target_suffix})
       rosidl_get_typesupport_target(c_typesupport_target "${PROJECT_NAME}" "rosidl_typesupport_c")
-      target_link_libraries(${target}${target_suffix} "${c_typesupport_target}")
-      ament_target_dependencies(${target}${target_suffix}
-        "osrf_testing_tools_cpp" "rcl")
+      target_link_libraries(${target}${target_suffix}
+        "${c_typesupport_target}"
+        osrf_testing_tools_cpp::memory_tools
+        rcl::rcl
+      )
       set_tests_properties(
         ${target}${target_suffix}
         PROPERTIES REQUIRED_FILES "$<TARGET_FILE:${target}${target_suffix}>"
@@ -188,32 +190,6 @@ if(BUILD_TESTING)
       set(rmw_implementation2_is_connext TRUE)
     endif()
 
-    # TODO(asorbini) Skip tests between rmw_connext_cpp and rmw_connextdds
-    # since they are not meant to coexist (and used incompatible typecodes by default).
-    set(rmw_implementation1_is_connextdds FALSE)
-    if(rmw_implementation1 MATCHES "(.*)connextdds")
-      set(rmw_implementation1_is_connextdds TRUE)
-    endif()
-    set(rmw_implementation2_is_connextdds FALSE)
-    if(rmw_implementation2 MATCHES "(.*)connextdds")
-      set(rmw_implementation2_is_connextdds TRUE)
-    endif()
-
-    set(rmw_implementation1_is_connext_cpp FALSE)
-    if(rmw_implementation1 MATCHES "(.*)connext(.*)_cpp")
-      set(rmw_implementation1_is_connext_cpp TRUE)
-    endif()
-    set(rmw_implementation2_is_connext_cpp FALSE)
-    if(rmw_implementation2 MATCHES "(.*)connext(.*)_cpp")
-      set(rmw_implementation2_is_connext_cpp TRUE)
-    endif()
-
-    if((rmw_implementation1_is_connextdds AND rmw_implementation2_is_connext_cpp) OR
-      (rmw_implementation1_is_connext_cpp AND rmw_implementation2_is_connextdds)
-    )
-      set(SKIP_TEST "SKIP_TEST")
-    endif()
-
     set(rmw_implementation1_is_cyclonedds FALSE)
     set(rmw_implementation2_is_cyclonedds FALSE)
     if(rmw_implementation1 MATCHES "(.*)cyclonedds(.*)")
@@ -281,11 +257,7 @@ if(BUILD_TESTING)
 
     # TODO(mikaelarguedas) Simpler way to blacklist specific tests (e.g. regex matching)
     # TODO different vendors can't talk to each other right now
-    # TODO(asorbini): Remove Connext exceptions once ros2/rmw_connext is deprecated.
-    if(NOT rmw_implementation1 STREQUAL rmw_implementation2 OR
-      (client_library1 STREQUAL "rclpy" AND rmw_implementation1 MATCHES "rmw_connext_dynamic_cpp") OR
-      (client_library2 STREQUAL "rclpy" AND rmw_implementation2 MATCHES "rmw_connext_dynamic_cpp")
-    )
+    if(NOT rmw_implementation1 STREQUAL rmw_implementation2)
       set(SKIP_TEST "SKIP_TEST")
     endif()
 
@@ -426,9 +398,10 @@ if(BUILD_TESTING)
     "test/subscribe_array_types.cpp"
     "test/subscribe_basic_types.cpp"
     "test/subscribe_string_types.cpp")
-  ament_target_dependencies(subscribe_types
-    "rclcpp"
-    "test_msgs")
+  target_link_libraries(subscribe_types
+    rclcpp::rclcpp
+    ${test_msgs_TARGETS}
+  )
 
   # publisher combined with a subscriber
   custom_executable(test_publisher_subscriber_cpp
@@ -493,29 +466,23 @@ if(BUILD_TESTING)
   endif()
 
   macro(serialize)
-    # TODO(asorbini): Remove this exception once ros2/rmw_connext is deprecated.
-    set(SKIP_TEST "")
-    if(${rmw_implementation} STREQUAL "rmw_connext_dynamic_cpp")
-      message(STATUS "skipping serialize tests for ${rmw_implementation}")
-      set(SKIP_TEST "SKIP_TEST")
-    endif()
-
     set(serialize_target_name "test_serialize${target}${target_suffix}")
     ament_add_gtest(
       ${serialize_target_name} test/test_message_serialization.cpp
       TIMEOUT 30
       ENV
       RCL_ASSERT_RMW_ID_MATCHES=${rmw_implementation}
       RMW_IMPLEMENTATION=${rmw_implementation}
-      ${SKIP_TEST}
     )
     if(TARGET ${serialize_target_name})
       add_dependencies(${serialize_target_name} ${PROJECT_NAME})
+      target_link_libraries(${serialize_target_name}
+        rmw::rmw
+        rosidl_typesupport_c::rosidl_typesupport_c
+        rosidl_typesupport_cpp::rosidl_typesupport_cpp
+        ${test_msgs_TARGETS}
+      )
       ament_target_dependencies(${serialize_target_name}
-        "rmw"
-        "rosidl_typesupport_c"
-        "rosidl_typesupport_cpp"
-        "test_msgs"
         ${rmw_implementation}
       )
       set_tests_properties(
@@ -526,31 +493,25 @@ if(BUILD_TESTING)
   endmacro()
 
   macro(pub_sub_serialized)
-    # TODO(asorbini): Remove this exception once ros2/rmw_connext is deprecated.
-    set(SKIP_TEST "")
-    if(${rmw_implementation} STREQUAL "rmw_connext_dynamic_cpp")
-      message(STATUS "skipping serialize tests for ${rmw_implementation}")
-      set(SKIP_TEST "SKIP_TEST")
-    endif()
-
     set(target_name "test_publisher_subscriber_serialized${target}${target_suffix}")
     ament_add_gtest(
       ${target_name} test/test_publisher_subscriber_serialized.cpp
       TIMEOUT 30
       ENV
       RCL_ASSERT_RMW_ID_MATCHES=${rmw_implementation}
       RMW_IMPLEMENTATION=${rmw_implementation}
-      ${SKIP_TEST}
     )
     if(TARGET ${target_name})
       add_dependencies(${target_name} ${PROJECT_NAME})
+      target_link_libraries(${target_name}
+        rclcpp::rclcpp
+        rclcpp_action::rclcpp_action
+        rmw::rmw
+        rosidl_typesupport_c::rosidl_typesupport_c
+        rosidl_typesupport_cpp::rosidl_typesupport_cpp
+        ${test_msgs_TARGETS}
+      )
       ament_target_dependencies(${target_name}
-        "rclcpp"
-        "rclcpp_action"
-        "rmw"
-        "rosidl_typesupport_c"
-        "rosidl_typesupport_cpp"
-        "test_msgs"
         ${rmw_implementation}
       )
       set_tests_properties(

diff --git a/test_quality_of_service/CMakeLists.txt b/test_quality_of_service/CMakeLists.txt
@@ -44,7 +44,11 @@ if(BUILD_TESTING)
   ament_find_gtest()
   target_compile_definitions(${PROJECT_NAME}_support PRIVATE
     "TEST_QUALITY_OF_SERVICE_BUILDING_LIBRARY")
-  ament_target_dependencies(${PROJECT_NAME}_support rclcpp rcutils std_msgs)
+  target_link_libraries(${PROJECT_NAME}_support
+    rclcpp::rclcpp
+    rcutils::rcutils
+    ${std_msgs_TARGETS}
+  )
 
   function(add_custom_gtest target)
     ament_add_gtest(${target}${target_suffix} ${ARGN}
@@ -54,8 +58,14 @@ if(BUILD_TESTING)
     )
     target_compile_definitions(${target}${target_suffix}
       PUBLIC "RMW_IMPLEMENTATION=${rmw_implementation}")
-    target_link_libraries(${target}${target_suffix} ${PROJECT_NAME}_support)
-    ament_target_dependencies(${target}${target_suffix} rcl rclcpp rcutils std_msgs test_msgs)
+    target_link_libraries(${target}${target_suffix}
+      ${PROJECT_NAME}_support
+      rcl::rcl
+      rclcpp::rclcpp
+      rcutils::rcutils
+      ${std_msgs_TARGETS}
+      ${test_msgs_TARGETS}
+    )
   endfunction()
 
   macro(tests)

diff --git a/test_security/CMakeLists.txt b/test_security/CMakeLists.txt
@@ -43,8 +43,10 @@ if(BUILD_TESTING)
 
   function(custom_executable target)
     add_executable(${target} ${ARGN})
-    ament_target_dependencies(${target}
-      "rclcpp" "test_msgs")
+    target_link_libraries(${target}
+      rclcpp::rclcpp
+      ${test_msgs_TARGETS}
+    )
   endfunction()
 
   function(custom_security_test_c target)
@@ -61,9 +63,10 @@ if(BUILD_TESTING)
     if(TARGET ${target}${target_suffix})
       target_link_libraries(${target}${target_suffix}
         ${_AMENT_EXPORT_ABSOLUTE_LIBRARIES}
-        ${_AMENT_EXPORT_LIBRARY_TARGETS})
-      ament_target_dependencies(${target}${target_suffix}
-        "rcl" "osrf_testing_tools_cpp")
+        ${_AMENT_EXPORT_LIBRARY_TARGETS}
+        rcl::rcl
+        osrf_testing_tools_cpp::memory_tools
+      )
       set_tests_properties(
         ${target}${target_suffix}
         PROPERTIES REQUIRED_FILES "$<TARGET_FILE:${target}${target_suffix}>"