Corrected publish calls with shared_ptr signature #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpauno
added
in progress
|
In several cases same comment as here: ros2/rclcpp#709 (comment) |
ivanpauno
force-pushed
the
ivanpauno/deprecate-shared-ptr-publish
branch
from
6a81d50
to
5b244fe
Compare
sloretz
approved these changes
May 2, 2019
ivanpauno
force-pushed
the
ivanpauno/deprecate-shared-ptr-publish
branch
from
d92ad62
to
4637bd3
Compare
wjwwood
force-pushed
the
ivanpauno/deprecate-shared-ptr-publish
branch
from
4637bd3
to
0ff034c
Compare
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
ivanpauno
force-pushed
the
ivanpauno/deprecate-shared-ptr-publish
branch
from
0ff034c
to
197d244
Compare
wjwwood
approved these changes
May 6, 2019
delete-merged-branch
bot
deleted the
ivanpauno/deprecate-shared-ptr-publish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rclcpp#709