Simplify the test_secure_subscriber code. (backport #471) #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The main reason to do this is that we were sometimes running out of memory on the buildfarm while building this code. I suspect that it is because of the templated attempt_subscriber() functions that had to get expanded for quite a few different messages. However, it turns out that we were only ever using 2 of those messages in tests themselves. Simplify this whole thing by only creating templated functions for the messages we are actually going to use. Similarly, simplify the quite complicated CMake logic a bit to only have a list of the messages that we are going to actually use. If we want to add more messages in the future, we can always expand this list again. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit 8fc14b4)
|
This will help prevent OOM errors on Galactic, like we see in https://ci.ros2.org/view/nightly/job/nightly_linux_galactic_coverage/26/ . |
|
CI:
|
cottsay
approved these changes
May 20, 2021
|
I'm going to go ahead and merge this one, as we don't release system_tests into the distributions. Hence, it will have no impact on binary Debian/RPM packages, and we already have green CI above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #471 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/