Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_msgs dependency to "custom_executable" targets in test_communication #497

Merged
merged 1 commit into from Mar 15, 2022

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 14, 2022

Used here

#include "test_msgs/service_fixtures.hpp"

#include "test_msgs/message_fixtures.hpp"

#include "test_msgs/message_fixtures.hpp"

#include "test_msgs/message_fixtures.hpp"

#include "test_msgs/service_fixtures.hpp"

#include "test_msgs/action/fibonacci.hpp"
#include "test_msgs/action/nested_message.hpp"

#include "test_msgs/action/fibonacci.hpp"
#include "test_msgs/action/nested_message.hpp"

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the bug Something isn't working label Mar 14, 2022
@sloretz sloretz self-assigned this Mar 14, 2022
@sloretz
Copy link
Contributor Author

sloretz commented Mar 14, 2022

CI (build: --packages-up-to test_communication test: --packages-select test_communication)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Mar 15, 2022

I think the two windows tests that failed must be flaky, but they're not very flaky.

projectroot.test_publisher_subscriber__rclpy__rmw_fastrtps_cpp
projectroot.test_publisher_subscriber__rclcpp__rclpy__rmw_fastrtps_cpp

The last repeated nightly I see a failure is a couple nights ago https://ci.ros2.org/view/nightly/job/nightly_win_rep/2550/#showFailuresLink

I can't see how explicitly adding a dependency it must be getting transitively now could cause a test failure, so I'll merge this anyways.

@sloretz sloretz merged commit 4fe90b6 into master Mar 15, 2022
@sloretz sloretz deleted the sloretz__test_msgs__dep_test_msgs branch March 15, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants