Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract sros_artifacts fixture into a CMake script #525

Merged
merged 1 commit into from Aug 8, 2023

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Aug 8, 2023

All of these commands should be run together to set up the fixture for the tests. When running tests with repitition, we want to run through the entire artifact setup and not run each individual command multiple times.

Fixes #522

CI, using --retest-until-fail 2:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

All of these commands should be run together to set up the fixture for
the tests. When running tests with repitition, we want to run through
the entire artifact setup and not run each individual command multiple
times.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay added the bug Something isn't working label Aug 8, 2023
@cottsay cottsay self-assigned this Aug 8, 2023
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this properly, then we are essentially treating sros_artifacts.cmake as a test script and executing the entirety of it before each test invocation. Is that correct?

Could we also make this test an e.g. Python script instead? I actually don't care that much whether we keep this as CMake or a script, but I just wanted to mention that as a possibility.

@cottsay
Copy link
Member Author

cottsay commented Aug 8, 2023

Is that correct?

Correct. In the presence of --retest-until-fail, the entire script will be run multiple times instead of the previous behavior, where each command was run multiple times.

Could we also make this test an e.g. Python script instead?

Absolutely - it's just easier to use CMake since that's what we're already using, rather than finding the Python executable to invoke a Python script.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@cottsay cottsay merged commit af74e9f into rolling Aug 8, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/test-fixtures branch August 8, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants