Test read condition #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,13 +14,20 @@ find_package(ament_cmake REQUIRED) | |||
|
|
|||
| if(AMENT_ENABLE_TESTING) | |||
| find_package(ament_lint_auto REQUIRED) | |||
| find_package(ament_cmake_gtest REQUIRED) | |||
There was a problem hiding this comment.
This line is not necessary since the next line does that already.
There was a problem hiding this comment.
Fixed in the test-services branch.
esteve
force-pushed
the
test-read-condition
branch
from
0058c67
to
482a0b6
Compare
|
|
||
| int main(int argc, char ** argv) | ||
| { | ||
| rclcpp::init(argc, argv); |
There was a problem hiding this comment.
Pass 0, nullptr instead of arc, argv.
Same below.
esteve
force-pushed
the
test-read-condition
branch
from
482a0b6
to
4041f1a
Compare
esteve
force-pushed
the
test-read-condition
branch
from
4041f1a
to
643a2c3
Compare
|
I would propose to close this in favor of #57. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an acceptance test for repeated requests to a service.
Connects to ros2/rclcpp#52
Depends on #42