Improve the node_name test. #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do a few things here:
1. Minor style updates, just to make the code easier to read.
2. Increase the timeout for finding the node from 10 seconds
to 15 seconds.
3. Change the call to the executor from spin_once to spin_some.
This means that we'll give the executor more opportunity to
do work, which may increase the chances of success.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
The main goal here is to try to make flakiness, like in https://ci.ros2.org/view/nightly/job/nightly_linux_repeated/3385/testReport/(root)/projectroot/test_node_name__rmw_cyclonedds_cpp__rmw_fastrtps_cpp/ , less likely. |
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a few things here: