New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README for Ros2 (#17) #18
Conversation
@nfry321 FYI, I retargeted this to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Overall, I really like the explanation of the topics, parameters, and launch file parameters. I've left a bunch of improvements inline. Once those are fixed, I think this is good to go in.
README.md
Outdated
@@ -1,4 +1,70 @@ | |||
teleop_twist_joy [![Build Status](https://travis-ci.org/ros-teleop/teleop_twist_joy.svg?branch=indigo-devel)](https://travis-ci.org/ros-teleop/teleop_twist_joy) | |||
ros2/teleop_twist_joy [![Build Status](https://travis-ci.org/ros-teleop/teleop_twist_joy.svg?branch=indigo-devel)](https://travis-ci.org/ros-teleop/teleop_twist_joy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the travis job here is wrong. I think we should just remove the link completely, since we don't use travis on this repository at all.
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
No problem, thanks for tidying those issues, they should now have been changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution.
The PR jobs are failing, but there is no way it can be because of this PR, so I'm going to go ahead and merge anyway.
No description provided.