Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for Ros2 (#17) #18

Merged
merged 10 commits into from Nov 5, 2020
Merged

Conversation

nfry321
Copy link

@nfry321 nfry321 commented Nov 5, 2020

No description provided.

@clalancette clalancette changed the base branch from dashing to eloquent November 5, 2020 14:05
@clalancette
Copy link

@nfry321 FYI, I retargeted this to the eloquent branch, which is the latest on this repository.

Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall, I really like the explanation of the topics, parameters, and launch file parameters. I've left a bunch of improvements inline. Once those are fixed, I think this is good to go in.

README.md Outdated
@@ -1,4 +1,70 @@
teleop_twist_joy [![Build Status](https://travis-ci.org/ros-teleop/teleop_twist_joy.svg?branch=indigo-devel)](https://travis-ci.org/ros-teleop/teleop_twist_joy)
ros2/teleop_twist_joy [![Build Status](https://travis-ci.org/ros-teleop/teleop_twist_joy.svg?branch=indigo-devel)](https://travis-ci.org/ros-teleop/teleop_twist_joy)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the travis job here is wrong. I think we should just remove the link completely, since we don't use travis on this repository at all.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
nfry321 and others added 2 commits November 5, 2020 14:23
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
@nfry321
Copy link
Author

nfry321 commented Nov 5, 2020

No problem, thanks for tidying those issues, they should now have been changed.

Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution.

The PR jobs are failing, but there is no way it can be because of this PR, so I'm going to go ahead and merge anyway.

@clalancette clalancette merged commit bbf19bb into ros2:eloquent Nov 5, 2020
@nfry321 nfry321 deleted the ros2-docs branch November 5, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants