add IdlOnlyTypes - even though they are commented out atm #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
hidmic
reviewed
Jun 5, 2019
|
I doubt that it will be added shortly. Therefore I think it makes sense to merge this as is. |
|
Hmm shouldn't it be added at least to all Tier 1 RMWs? |
That would be nice. But even then we wouldn't be able to enable it. If at least one RMW impl. doesn't support it the build would fail. |
|
Hmm, I see, we don't have a mechanism to selectively preclude message builds for some RMW typesupports. Alright, fair enough. |
|
Well, really the file get's built by whoever chooses to use variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ros2/rosidl#383.
This was mostly used to test
long doubleandwchartypes with FastRTPS. Until the other RMW impl. support this (ros2/rosidl_typesupport_connext#33, ros2/rosidl_typesupport_opensplice#31) the.idlfile is commented out.So currently this is a no-op but it allows to easily enable the file for testing in the future.