-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around Windows min/max bug. #21
Conversation
The comments in the code explain why we need this. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
subjectively I like #undef max
more than an empty macro, but I don't have any non-subjective reasons for choosing one over the other.
On balance, after looking at it more, I agree with you. I'm going to change to the other style and then run CI with that. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
FYI @clalancette windows CI looks like a java traceback, twice. 3rd attempt in progress: |
The comments in the code explain why we need this.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Some upcoming changes to pluginlib are going to cause us to
#include <windows.h>
, which is why this is now needed to build on Windows.One other note: I believe that there is an alternative way to solve this, which is to use MSVC push_macro/pop_macro. That is, we'd do something like:
Both are kind of ugly, so I don't have a strong opinion one way or another.