Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

avoid embedding the absolute install prefix in the artifacts #20

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

dirk-thomas
Copy link
Member

Addressing one part of ros2/ros2#606 to make the installed artifacts relocatable.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is there a way we can test the change?

@dirk-thomas
Copy link
Member Author

Is there a way we can test the change?

  • Compare the .pc file before / after
  • Run pkg-config --libs-only-L urdfdom before / after

@dirk-thomas dirk-thomas merged commit 4d16789 into ros2 Jun 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/avoid-absolute-install-prefix branch June 2, 2020 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants