use geometry2 metapackage in ros_base #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds the missing tf2_sensor_msgs package as well as add futureproofness for the packages that are not ported yet Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
tfoote
approved these changes
Oct 22, 2019
nuclearsandwich
approved these changes
Oct 22, 2019
mjcarroll
approved these changes
Oct 25, 2019
|
@ros-pull-request-builder retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds the missing
tf2_sensor_msgspackage and allows for other geometry2 packages to be ported without having to modify the variants. This change does not require a change to the REPRequires ros2/geometry2#184 to be released before merging
Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com