Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EndOfBuffer highlight group override not taking precedence #94

Closed
theteachr opened this issue Sep 17, 2022 · 3 comments
Closed

EndOfBuffer highlight group override not taking precedence #94

theteachr opened this issue Sep 17, 2022 · 3 comments

Comments

@theteachr
Copy link

After running PackerySync, and it notifying about the breaking change, my override of EndOfBuffer highlight group's fg is not respected, where they are white, instead of the said color.

image

@mvllow
Copy link
Member

mvllow commented Sep 17, 2022

  1. Does your ColorColumn override work?
  2. Could you try NonText instead of EndOfBuffer?

Appreciate the report :)

@theteachr
Copy link
Author

NonText works. Did something change in the update? Because I was able to control the same element with the EndOfBuffer.

@mvllow
Copy link
Member

mvllow commented Sep 23, 2022

Had to double check but our highlight function hasn't changed, so my best guess is perhaps another plugin update started theming EndOfBuffer or something in neovim core. Glad NonText works though :)

Edit: And to further confirm, both highlight_groups = { EndOfBuffer = { fg = 'rose' }} and highlight_groups = { NonText = { fg = 'rose' }} work for me on, using the latest neovim nightly.

@mvllow mvllow closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants