Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDITOR-LSP error in server side due to absolute uri passed by client #442

Closed
STICKnoLOGIC opened this issue Jun 7, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@STICKnoLOGIC
Copy link

I found out that everytime I try to connect to my php lsp (phpactor) using this lib throw an error on my server side due to not absolute uri/file path...

trying to debug and searching the source code leads me to URIUtils in io/github/rosemoe/sora/lsp/utils....

the expected uri/String path should be:
file:///path/to/workplace

but I end up getting:
file:/path/to/workspace

as you can see, the end result missing "//" between the path and file which cannot be parsed/access by the lsp server as its not the absolute file/path.

phone: android 9, vivo v9, not rooted, all storage permission granted.

want to pr but dont have time so I make an issue instead
hope it will be fixed! TIA

@Rosemoe Rosemoe added the bug Something isn't working label Jun 11, 2023
@Rosemoe
Copy link
Owner

Rosemoe commented Jul 4, 2023

After investigation, I found that file URI without host name can be simplified to 'file:/' instead of 'file:///'. 'file:///' is actually caused by an empty host name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants