Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rails < 4.0 compatability #3

Merged
merged 1 commit into from
Oct 7, 2013
Merged

Fix Rails < 4.0 compatability #3

merged 1 commit into from
Oct 7, 2013

Conversation

cpuguy83
Copy link
Contributor

@cpuguy83 cpuguy83 commented Oct 5, 2013

No description provided.

@rosenfeld
Copy link
Owner

I'm OK with using skip_before_filter for both cases and keep the code simpler. Would you mind sending me a new PR with this single change?

@cpuguy83
Copy link
Contributor Author

cpuguy83 commented Oct 5, 2013

Can certainly do that, but I think before_filter is going to be removed in 4.1... maybe 4.2

@rosenfeld
Copy link
Owner

Really? I haven't seen any deprecation note for it. Maybe on 4.2 but this may take a while. Do you think you'll be still using Rails 3 by then?

@cpuguy83
Copy link
Contributor Author

cpuguy83 commented Oct 5, 2013

True enough, I sincerely hope not.

@cpuguy83
Fix Rails < 4.0 compatability
eb4ee40 
Just use before_filter, no before_action
@cpuguy83
Copy link
Contributor Author

cpuguy83 commented Oct 6, 2013

I squashed the commits down, only shows as 1 commit.

rosenfeld added a commit that referenced this pull request Oct 7, 2013
@rosenfeld
Merge pull request #3 from cpuguy83/patch-1
9bfb91d 
Fix Rails < 4.0 compatibility
@rosenfeld rosenfeld merged commit 9bfb91d into rosenfeld:master Oct 7, 2013
@rosenfeld
Copy link
Owner

Thanks, Brian!

@cpuguy83
Copy link
Contributor Author

cpuguy83 commented Oct 7, 2013

Have you seen https://github.com/rails/web-console ?
Rails 4 only, but looks pretty sweet.

@cpuguy83 cpuguy83 deleted the patch-1 branch October 7, 2013 13:49
@rosenfeld
Copy link
Owner

I just released a patch version to RubyGems: http://rubygems.org/gems/rails-web-console

@rosenfeld
Copy link
Owner

Yes, I've even created the first PR there :)

@rosenfeld
Copy link
Owner

But it won't be of any use to me until they manage to export the request object to the REPL :) I mostly use the Repl under rails c and will only use my gem in the rare times I want to inspect the request object :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpuguy83 @rosenfeld