-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinate Frames #33
Comments
Related: byu-magicc/rosflight_plugins#4 |
From a practical perspective, I'm pretty determined to continue breaking REP. Haha. The aerospace literature in general follows a NED convention. ROS's origins are in ground robots, which use ENU. I don't know that it's super unreasonable to stick with a NED convention for MAVs. I know several people who have been incredibly confused by the switching of coordinate frames in mavros. I think that's probably the worst possible implementation (a hidden coordinate frame switch?) let's not do that. Anyway. I'm not super familiar with tf. Do you have any idea on how we might deal with that? In my implementation of |
Let's publish the attitude to tf. I think that would be a nice and easy way to visualize the attitude. |
We should confirm that coordinate frames have been unified within rosflight_io before closing this issue. |
What coordinate frame standard are we adopting for the ROSflight stack? It would be good to have a standard and have some solid documentation (with images) on this. Coordinate frames are a big source of confusion in robotics it seems.
This comes with some philosophical questions: ROS standard (REP 103 and REP 105) is ENU with body-NWU, which lends itself to ground robots. But the UAV community is NED.
If we break the ROS standard and use NED, it may make it more difficult/confusing to interface with other ROS packages. Also, for what it is worth,
mavros
follows the ROS standard, but didn't really seem to agree on it until well into the project. And even then, they seem to have had some errors in their understanding: mavlink/mavros#216It may also be worth considering
tf2
to help mitigate coordinate frame issues.The text was updated successfully, but these errors were encountered: