Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visualization tools #84

Merged
merged 2 commits into from
Nov 29, 2018
Merged

visualization tools #84

merged 2 commits into from
Nov 29, 2018

Conversation

plusk01
Copy link
Contributor

@plusk01 plusk01 commented Nov 26, 2018

Cleaned up the magnetometer visualization code. Renamed viz_mag to viz and folded in a republisher from rosflight_msgs/Attitude to geometry_msgs/PoseStamped so the attitude can be viewed in rviz.

The fact that the attitude portion of the viz is merely a republisher for mismatching message types makes me wonder if rosflight_io should be publishing on the tf tree? (see #33) Or maybe you don't think this viz code belongs in this repo? Visualization of attitude just seems like a natural thing to do to test ROSflight out-of-the-box.

Copy link
Contributor

@superjax superjax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @plusk01, there was some old code in there. I like your addition

I think it would be a good idea to publish to tf, though I have never done it. I'll update #33 and see if I or someone else has time to make that happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants