Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the magnetometer visualization code. Renamed
viz_mag
toviz
and folded in a republisher fromrosflight_msgs/Attitude
togeometry_msgs/PoseStamped
so the attitude can be viewed in rviz.The fact that the attitude portion of the viz is merely a republisher for mismatching message types makes me wonder if
rosflight_io
should be publishing on the tf tree? (see #33) Or maybe you don't think this viz code belongs in this repo? Visualization of attitude just seems like a natural thing to do to test ROSflight out-of-the-box.