Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bytes in serialize/deserialize methods #39

Merged
merged 2 commits into from
May 9, 2021
Merged

Use bytes in serialize/deserialize methods #39

merged 2 commits into from
May 9, 2021

Conversation

bonprosoft
Copy link
Member

buffer for those serialization methods handle bytes, so I updated those type annotations to BinaryIO and bytes.

@bonprosoft bonprosoft requested a review from otamachan May 8, 2021 17:34
This was referenced May 8, 2021
Merged
Merged
@bonprosoft bonprosoft added the bug Something isn't working label May 9, 2021
@bonprosoft bonprosoft merged commit 746fad4 into master May 9, 2021
@bonprosoft bonprosoft deleted the fix_serialization_type branch May 9, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otamachan otamachan Awaiting requested review from otamachan

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bonprosoft