Make AVL_TREE_SIZE a user-visible cmake option

[JohnPJenkins]

Right now it's set as a constant (in core/CMakeLists.txt). To change it, the builder needs to edit the CMakeLists.txt file by hand.

I run into this fairly often when scaling up models.

[laprej]

This can be modified by running ccmake as opposed to cmake. More often than not I actually run ccmake because it allows me to configure the build a little more precisely. I even use the 't' option to get at more advanced options sometimes. Does that work for you?

[JohnPJenkins]

Hmm, my process has been to get my flags and options set up in a little helper script then not really touch it afterwards. Never used ccmake before. I'll give it a try later on today and see how it goes.

[gonsie]

There have been a number of changes to the CMakeLists files for the new version of ROSS. We now try to avoid using the command line flags, and instead we have all of the options listed in config.h.

[JohnPJenkins]

I gave ccmake a try. It's an interesting alternative to specifying command line args, though not far removed :). Initial configuration (without a cmake cache) is pretty silly - it gives you an empty set of options, then you have to configure it (and deal with errors from not specifying required options such as ARCH) and wait for it to error out before you can configure it with the options you want.

Honestly still prefer a command-line approach with a help function that doesn't require you generate a working configuration first (aka, autotools), but this approach is good enough for incrementing a build variable like AVL_TREE_SIZE after the fact.

RE configure option specification - they need to be set from somewhere. Putting the result in a header is definitely a better approach over dumping everything in C(PP)FLAGS, but I don't see a curses-UI approach as any better, or worse, than a command-line-based one. That being said, I don't endorse autotools :).

[gonsie]

AVL_TREE_SIZE does not require a rebuild. I've just made it a command line flag!

[gonsie]

closed with commit 2b24ecf