Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET requests and the payload parameter #7

Open
asgeirb opened this issue Feb 18, 2020 · 1 comment
Open

GET requests and the payload parameter #7

asgeirb opened this issue Feb 18, 2020 · 1 comment

Comments

@asgeirb
Copy link

asgeirb commented Feb 18, 2020

In GET requests one must provide :payload "" in order to generate valid signatures. This is confusing and unnecessary.

This creates an invalid signature:
(aws-sign4:aws-sign4 :region :us-east-1
:service "route53"
:method :get
:host "route53.amazonaws.com"
:path "/2013-04-01/hostedzone")

This generates a valid signature:
(aws-sign4:aws-sign4 :region :us-east-1
:service "route53"
:method :get
:payload ""
:host "route53.amazonaws.com"
:path "/2013-04-01/hostedzone")

@asgeirb
Copy link
Author

asgeirb commented Feb 18, 2020

Looking at the code I see payload=nil creates a UNSIGNED-PAYLOAD request (used in s3), but maybe there should be a special case for GET requests (as unsigned-payload is not relevant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant