Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill_W not uncovering all zones till the map edge #16

Closed
Lexx2k opened this issue Jan 10, 2020 · 4 comments
Closed

Fill_W not uncovering all zones till the map edge #16

Lexx2k opened this issue Jan 10, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Lexx2k
Copy link
Contributor

Lexx2k commented Jan 10, 2020

Minor but somewhat annoying issue:

Unlike in Fo1, the Fill_W flag in Fo2 (set in worldmap.txt) doesn't uncover zones up to the very end of the left screen side.

Ocean

This is some odd behavior, as it doesn't look consistent... Here is the Fo1 worldmap with the zones and how they will uncover right now: https://i.imgur.com/vjz4BJi.png

As you can see, everything works fine until we are reaching the zone row at the height of the cathedral location. There suddenly Fill_W doesn't reach to the map border anymore.
That gets worse once more in the very last row.

Maybe there is some engine limitation going on here?
Anything we can do about this?

@Lexx2k Lexx2k added the bug Something isn't working label Jan 10, 2020
@CyberMayck
Copy link
Contributor

From looking at it and walking around the map it is obvious that the map being uncovered is limited by Tile borders (since tiles are 7x6 zones and its 7 or 14 zones missing from the map edge).

Also at the very bottom line of the map there are two zones you can step on to with that reveal flag. And since each is on different tile and one reveals 7 zones to the left and other reveals 13 it easily demonstrates how it actually works:

When the reveal zone is stepped on, it reveals rest of the zones to the left in the current worldmap tile and also all zones in one worldmap tile further to the left.

So it would somehow need to check, if there are additional Tiles beyond that and reveal those. Since didn't have ocean that would be wider than two worldmap tiles, it does not happen there. This probably requires some deeper knowledge to fix...

@Lexx2k
Copy link
Contributor Author

Lexx2k commented Jan 12, 2020

Another note to this:
I tried to workaround this with giving all zones to the left the Fill_W flag, but sadly the game doesn't recognize them. So it seems the player must step on these zones- just revealing them does not trigger the Fill_W flag-effect.

@Lexx2k
Copy link
Contributor Author

Lexx2k commented Jan 13, 2020

We have added a script solution for this. df4100a

Problem is that it works with a noticable delay, so ultimately fixing this "in engine" would be preferable.

@Lexx2k Lexx2k added enhancement New feature or request and removed bug Something isn't working labels Jan 13, 2020
@ghost2238 ghost2238 self-assigned this Jan 31, 2020
ghost2238 added a commit that referenced this issue Jan 31, 2020
Probably possible to do it less code and by reusing existing code better, but this should be an ok implementation. #16
@ghost2238
Copy link
Member

I've implemented this as a bytepatch in script, see 87750f8, should be possible to remove the script code in gl_worldmap.ssl now that we have a proper solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants