Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot/Kusama support #1081

Closed
yangwao opened this issue Jun 11, 2020 · 11 comments
Closed

Polkadot/Kusama support #1081

yangwao opened this issue Jun 11, 2020 · 11 comments
Labels
enhancement New feature or request new chain Request for native support of a new chain

Comments

@yangwao
Copy link

yangwao commented Jun 11, 2020

Abstract

As Kusama growing bigger I see the potential for Rotki to capture new userbase and it will help to adapt for other para/solochains based on Substrate

I know I'm still the one 😅 and also that bothers me 🤗, let's change it.

Motivation

I'm going to stake KSM and I would like to see P/E for example, account commission fee and yield :)

Actual Staking Interface from polkadot.js.org
image

Specification

This could be really wild and I don't have anything specific in my mind right now!
Just created this as coordination issue so it could potentially attract others to play with it 😇


Grant

For Kusama support we are receiving a grant to implement it in two milestones. Once both milestones are finished we can close this issue. Source: https://docs.google.com/document/d/1OwdIcrAqDxMpDcIRTE7wbJU0aO2gGfZplyEI7s1oWPo/edit#

I will link all sub-issues here and in the OP so they can be easily followed:

Milestone 1

Milestone 2

  • Perform transaction history query for the imported addresses by using the a KSM node and show them in the Rotki UI in the blockchain transactions component
  • Detect if any of the user’s addresses are actively staking, and if yes show how much profit they have made (counting historical KSM prices) and show expected profits in the UI. Also calculate profit for addresses that have staked so far in the past.
  • Create a new UI component for staking in Rotki. There multiple blockchains that allow staking would be shown and KSM would be one of them. Show staking details in this component.
@LefterisJP
Copy link
Member

Hey @yangwao, thanks for the issue!
As I asked in Twitter isn't Kusama a testnet? Shouldn't this issue be for polkadot mainnet instead? Perhaps there is something I am misunderstanding but why would you want accounting/portfolio tracking for a testnet?

@yangwao yangwao changed the title Kusama support Polkadot/Kusama support Jun 11, 2020
@yangwao
Copy link
Author

yangwao commented Jun 11, 2020

@LefterisJP Well, technically it's Litecoin to Bitcoin, but it has users. 😅
KSM went from $2 to almost $5 and over, so I think if there is value, it's worth accounting it.

There is bleeding-edge governance tested at Kusama first. A lot of integrations are being set there. Polkadot will eventually adapt those things latter.

I think it's a test net with value.

@LefterisJP
Copy link
Member

I was not aware of that. If it has value it definitely makes sense to be tracked. Thank you for that info @yangwao.

@0xadri
Copy link

0xadri commented Aug 24, 2020

+1

Note that its probably quite urgent:

DOT (Polkadot token) entered the Top 10 coins on CoinGecko: https://www.coingecko.com/en/coins/polkadot

And KSM (Kusama) in the top 100s.

@LefterisJP
Copy link
Member

This issue is for blockchain integration with Substrate-like blockchains. Not simply for querying balance of DOT/KSM if it's in an exchange. If it's just the latter it's supported in develop and will be in the next release.

@0xadri
Copy link

0xadri commented Aug 25, 2020 via email

@LefterisJP
Copy link
Member

For Kusama support we are receiving a grant to implement it in two milestones. Once both milestones are finished we can close this issue. Source: https://docs.google.com/document/d/1OwdIcrAqDxMpDcIRTE7wbJU0aO2gGfZplyEI7s1oWPo/edit#

I will link all sub-issues here and in the OP so they can be easily followed:

Milestone 1

Milestone 2

  • Perform transaction history query for the imported addresses by using the a KSM node and show them in the Rotki UI in the blockchain transactions component
  • Detect if any of the user’s addresses are actively staking, and if yes show how much profit they have made (counting historical KSM prices) and show expected profits in the UI. Also calculate profit for addresses that have staked so far in the past.
  • Create a new UI component for staking in Rotki. There multiple blockchains that allow staking would be shown and KSM would be one of them. Show staking details in this component.

@0xadri
Copy link

0xadri commented Dec 21, 2020 via email

@vnavascues
Copy link
Contributor

vnavascues commented Feb 16, 2021

Milestone 2

Epic 1: transactions history query

Epic 2: staking

  • Support Kusama staking via an indexer

@bloxster
Copy link

Looking forward to be able to query also Polkadot network balances.

Big thanks to the team for the incredible work done so far.

@aspiers aspiers added enhancement New feature or request new chain Request for native support of a new chain labels Feb 28, 2021
@LefterisJP
Copy link
Member

This has been implemented. Both polkadot and KSM balances are supported.

We still miss specific things such as transactions and staking info but there are issues for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new chain Request for native support of a new chain
Projects
None yet
Development

No branches or pull requests

6 participants