Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable user to force-refresh balance queries. #168

Closed
kascheri12 opened this issue Sep 24, 2018 · 4 comments · Fixed by #584
Closed

Enable user to force-refresh balance queries. #168

kascheri12 opened this issue Sep 24, 2018 · 4 comments · Fixed by #584
Assignees

Comments

@kascheri12
Copy link
Contributor

kascheri12 commented Sep 24, 2018

Problem Definition

Note: @LefterisJP edited this issue to add more information for a generic solution that will satisfy force querying of all types of balances.

Original Request by @kascheri12:

Need a way to force refresh exchange balances.

I made a trade on exchange, new balances were not reflected in rotkehlchen until quit/reopen.

I tried using Command+R and logging in again. I tried navigating to different pages (User Settings, Tax Report, etc) and then back to Dashboard but balances didn't change. Balances were finally updated once I quit, relaunched, and logged in.

We need a way to be able to ask for a force refresh of balances of each location independently at any point in time. And this should also ignore the cache (?).

Task

Frontend Work

  • Add force refresh buttons on top of the dashboard's boxes for each exchange
  • Add force refresh buttons on top of the dashboard's boxes for blockchain balances
  • (Maybe?) add force refresh button for blockchain balances also on the user settings page.

Backend Work

Add an option to all the above endpoints to ignore the cache checks.

@LefterisJP
Copy link
Member

Hmmm that's interesting. There is a cache so that we don't make too many RPC calls to exchanges, but that should be max 10 minutes. Did you wait more than 10 mins or just restarted before that?

@kascheri12
Copy link
Contributor Author

No, definitely didn't wait 10 minutes.

@LefterisJP
Copy link
Member

But anyway this should be configurable as you said.

LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Feb 17, 2019
Related to rotki#168
Still need to somehow make it configurable.
LefterisJP added a commit that referenced this issue Feb 17, 2019
Related to #168
Still need to somehow make it configurable.
@LefterisJP LefterisJP changed the title Need a way to force refresh exchange balances. Enable user to force-refresh balance queries. Dec 26, 2019
@LefterisJP LefterisJP added this to To do in Release v1.1.0 Dec 26, 2019
@LefterisJP
Copy link
Member

Edited the original description of the issue to make the scope a bit more generic and specify what needs to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants