Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitstamp trades, deposits, withdrawals are no longer pulled properly #3033

Closed
LefterisJP opened this issue Jun 1, 2021 · 1 comment
Closed

Bitstamp trades, deposits, withdrawals are no longer pulled properly #3033

LefterisJP opened this issue Jun 1, 2021 · 1 comment
Assignees
@LefterisJP
Milestone
v1.17.2

Comments

@LefterisJP
Copy link
Member

LefterisJP commented Jun 1, 2021 •
edited
Loading

Problem Definition

I have a bitstamp api key which seems to be unable to pull trades history. More details on the why are still under investigation

Bitstamp dev-rugged us 😡

They changed the type of an event from an int to a str. So.

{"type": 0} -> {"type": "0"}

No api version change happened. They just merrily went and changed the response of an already established API endpoint.

So excuse my 🇫🇷 French but FUCK YOU Bitstamp.

Task

Fix it.
@LefterisJP LefterisJP changed the title Bitstamp trade history may not be properly pulled under some circumstances Bitstamp trades, deposits, withdrawals are not pulled properly Jun 1, 2021
@LefterisJP LefterisJP changed the title Bitstamp trades, deposits, withdrawals are not pulled properly Bitstamp trades, deposits, withdrawals are no longer pulled properly Jun 1, 2021
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Jun 1, 2021
@LefterisJP
Bitstramp trades, deposits, withdrawals history should work again
09dca72 
Fix rotki#3033

by making sure the type is always cast to an int
@LefterisJP LefterisJP mentioned this issue Jun 1, 2021
Merged
@LefterisJP LefterisJP added this to the v1.17.2 milestone Jun 1, 2021
@LefterisJP LefterisJP self-assigned this Jun 1, 2021
@LefterisJP
Copy link
Member Author

Fixed by #3034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LefterisJP LefterisJP

Labels
None yet
Projects
None yet
Milestone
v1.17.2
Development

No branches or pull requests
1 participant
@LefterisJP