Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEX Trades in trades history view do not have a link #3349

Closed
LefterisJP opened this issue Aug 18, 2021 · 1 comment
Closed

DEX Trades in trades history view do not have a link #3349

LefterisJP opened this issue Aug 18, 2021 · 1 comment
Labels
easy Easy issue. But maybe not good first. Fast if you are a bit familiar. good first issue Good for newcomers
Milestone
1.20.1

Comments

@LefterisJP
Copy link
Member

Problem Definition

Rotki keeps AMM swaps in the database for each AMM protocol we support. When converting them to a trade in order to show them in the trades history view we do not populate the link field with a link to the transaction hash, even though we actually have this information.

DEX Trades View

2021-08-18_23-03

Trades History View

2021-08-18_23-02

Task

Fix it by adding the link to the generated trade.
@LefterisJP LefterisJP added this to the 1.20.1 milestone Aug 18, 2021
@LefterisJP LefterisJP added easy Easy issue. But maybe not good first. Fast if you are a bit familiar. good first issue Good for newcomers labels Aug 18, 2021
@defi-caratacus defi-caratacus mentioned this issue Aug 19, 2021
Merged
defi-caratacus added a commit to defi-caratacus/rotki that referenced this issue Aug 19, 2021
@defi-caratacus
Add link to the Defitrade swap in trades history
5693bbb 
Fix rotki#3349
@LefterisJP
Copy link
Member Author

Closed by #3351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy Easy issue. But maybe not good first. Fast if you are a bit familiar. good first issue Good for newcomers
Projects
None yet
Milestone
1.20.1
Development

No branches or pull requests
1 participant
@LefterisJP