Adding UI tests #207
Merged
Adding UI tests #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still a WIP right? Make sure to also add changelog entries when it's done |
|
Yes it is still work in progress, I want to add a few more tests for the dashboard first before the review. |
|
@LefterisJP It should be ready for review. |
|
@kelsos Thanks a bunch! Seems that 2 UI tests in appveyor are still flaky though |
|
@LefterisJP I will go through them to find the flakiness cause and fix it. |
When adding a btc account for the fist time the table variable would be undefined and that would cause an error. Also fixes the reloading of the table since BTC table is an AssetTable.
Adds os:unstable to appveyor configuration as suggested in spectron github
|
@kelsos Thank you very much for this. UI tests were desperately needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
btcchain_per_accounttable initialization when adding a new btc account, and the reloading of the table when you are change a currency while in theuser_settingspage.Closes #209
Closes #206
Closes #41