Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing fiat currency does not change manually tracked balances value column title #895

Closed
LefterisJP opened this issue Apr 17, 2020 · 1 comment · Fixed by #902
Closed

Changing fiat currency does not change manually tracked balances value column title #895

LefterisJP opened this issue Apr 17, 2020 · 1 comment · Fixed by #902
Labels
bug Something isn't working frontend good first issue Good for newcomers
Milestone
v1.4.1

Comments

@LefterisJP
Copy link
Member

Problem Definition

Seen in v1.4.0 by @cryptomole1

Changing the FIAT currency via the drop-down menu if the user has manually tracked balances changes the value but not the title of the column. The title of the column is stuck to being USD Value.

I can confirm the problem, just tested it.

Task

  • Fix it
  • Write a unit test
@LefterisJP LefterisJP added bug Something isn't working frontend good first issue Good for newcomers labels Apr 17, 2020
@LefterisJP LefterisJP added this to the v1.4.1 milestone Apr 17, 2020
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Apr 17, 2020
@LefterisJP
Gracefully handle manually tracked balance that cant query price
6bec844 
Fix rotki#895
@LefterisJP LefterisJP reopened this Apr 18, 2020
@LefterisJP
Copy link
Member Author

Should not have been closed :)

@kelsos kelsos mentioned this issue Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend good first issue Good for newcomers
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging a pull request may close this issue.

Fixes manually tracked balances value column header not updating properly kelsos/rotki
1 participant
@LefterisJP