Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize Zerion DeFi SDK #921

Closed
LefterisJP opened this issue Apr 24, 2020 · 3 comments
Closed

Utilize Zerion DeFi SDK #921

LefterisJP opened this issue Apr 24, 2020 · 3 comments
Assignees
Milestone

Comments

@LefterisJP
Copy link
Member

Abstract

Thanks a lot to @isidorosp for bringing the Zerion SDK to our attention!

Integrating each new DeFi protocol with Rotki is time consuming. There are many facets to such integration. UI components, backend work and naturally ethereum chain querying.

Zerio has an opensource SDK for querying multiple DeFi protocols with fewer RPC calls.

They have deployed verified smart contracts to the ethereum mainnet that aggregate queries to different DeFi protocols and return results all in one (or just fewer calls).

This would be useful for Rotki since it would greatly reduce the number of RPC calls made for ethereum DeFi querying. And that is really important, especially if the user does not have his own node and relies on external services such as etherscan for those queries.

They have a javascript SDK, but we would need a python wrapper, which we can create ourselves if it does not exist.

Task

  • Figure out if there is a python wrapper. If not write it ourselves.
  • Adapt MakerDAO DSR calls (if supported to use it)
  • Use it in MakerDAO Vault calls
  • As more DeFi protocols are added utilize the aggregator instead of querying each protocol individually.
@rockfridrich
Copy link

Hey @LefterisJP
I am happy that your team finds our SDK useful for your product. We don’t have JS & Python libraries yet. However you can query AdaterRegistry (api.zerion.eth ENS) smart contract directly using web3.py and ABI published on Etherscan.

@rockfridrich
Copy link

We released a simple wrapper for Python — https://pypi.org/project/defisdk/

@LefterisJP
Copy link
Member Author

Hey @rockfridrich any news on when can the python adapter be opensource?

We can't use a closed source package.

But as you said we can call the adapter registry directly which is going to work for some things. We can experiment with it for now.

LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Jun 21, 2020
@LefterisJP LefterisJP added this to the v1.6.0 milestone Jul 4, 2020
@LefterisJP LefterisJP added this to To do in Next minor release via automation Jul 4, 2020
@LefterisJP LefterisJP self-assigned this Jul 4, 2020
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Jul 22, 2020
Next minor release automation moved this from To do to Done Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants