Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show all DeFi Balances in the User Interface #1124

Closed
2 tasks done
LefterisJP opened this issue Jul 4, 2020 · 0 comments · Fixed by #1179
Closed
2 tasks done

Show all DeFi Balances in the User Interface #1124

LefterisJP opened this issue Jul 4, 2020 · 0 comments · Fixed by #1179
Labels
ETH DeFi A feature concerning Ethereum Decentralized Finance frontend
Projects
Next minor release
Milestone
v1.6.0

Comments

@LefterisJP
Copy link
Member

LefterisJP commented Jul 4, 2020 •
edited by isidorosp

Abstract

Thanks to #921 we can now very easily get current DeFi balances for all DeFi protocols supported by Zerion contracts. All queries happen in a single RPC contract call per address speeding things up a lot.

This should also solve #1099

Task

For how to show them in the frontend, we should probably have:

  1. A DeFi balances section in the dashboard where it would show the total value locked in each protocol the user is using
  2. By clicking on each protcool it would take you to the respective component page where you could see a breakdown of the locked balances. And for some, for which we support also historical queries (in premium mode) the user can also see more info. Such as in Aave.
@LefterisJP LefterisJP added this to the v1.6.0 milestone Jul 4, 2020
@LefterisJP LefterisJP added this to To do in Next minor release via automation Jul 4, 2020
@LefterisJP LefterisJP mentioned this issue Jul 6, 2020
Merged
@isidorosp isidorosp linked a pull request Jul 22, 2020 that will close this issue
Introduces overview of defi protocols #1179
Merged
@isidorosp isidorosp added ETH DeFi A feature concerning Ethereum Decentralized Finance frontend labels Jul 22, 2020
Next minor release automation moved this from To do to Done Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ETH DeFi A feature concerning Ethereum Decentralized Finance frontend
Projects
No open projects
Next minor release
  
Done
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

Introduces overview of defi protocols kelsos/rotki
2 participants
@isidorosp @LefterisJP