Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all DeFi balances querying #1126

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Conversation

LefterisJP
Copy link
Member

WIP.

Fix backend part of #1124

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #1126 into develop will increase coverage by 0.12%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1126      +/-   ##
===========================================
+ Coverage    73.40%   73.53%   +0.12%     
===========================================
  Files          229      229              
  Lines        15119    15151      +32     
  Branches      2143     2149       +6     
===========================================
+ Hits         11098    11141      +43     
+ Misses        3439     3431       -8     
+ Partials       582      579       -3     
Flag Coverage Δ
#backend 81.12% <72.72%> (+0.14%) ⬆️
#frontend_integration 54.56% <ø> (ø)
#frontend_unit 19.25% <ø> (ø)
Impacted Files Coverage Δ
rotkehlchen/api/server.py 82.27% <ø> (ø)
rotkehlchen/api/rest.py 85.35% <57.89%> (-0.67%) ⬇️
rotkehlchen/chain/ethereum/zerion.py 92.30% <83.33%> (+0.52%) ⬆️
rotkehlchen/api/v1/resources.py 97.62% <100.00%> (+0.03%) ⬆️
rotkehlchen/serialization/serialize.py 100.00% <100.00%> (ø)
rotkehlchen/premium/premium.py 78.28% <0.00%> (-5.93%) ⬇️
rotkehlchen/chain/manager.py 84.02% <0.00%> (-0.66%) ⬇️
rotkehlchen/exchanges/poloniex.py 76.60% <0.00%> (+0.29%) ⬆️
rotkehlchen/exchanges/bittrex.py 81.77% <0.00%> (+0.46%) ⬆️
rotkehlchen/externalapis/etherscan.py 72.09% <0.00%> (+0.58%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d519771...e945147. Read the comment docs.

@LefterisJP LefterisJP merged commit a30b180 into rotki:develop Jul 6, 2020
@LefterisJP LefterisJP deleted the workon_1124 branch July 6, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant