Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aave fix for borrowing #1137

Merged
merged 3 commits into from Jul 11, 2020
Merged

Aave fix for borrowing #1137

merged 3 commits into from Jul 11, 2020

Conversation

LefterisJP
Copy link
Member

  • Fix aave balance query for borrowed assets
  • Add special case for LEND query since Zerion SDK does not detect it

kelsos
kelsos approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for the fix

@LefterisJP LefterisJP mentioned this pull request Jul 11, 2020
Closed
@LefterisJP
Copy link
Member Author

Merging. The OSX tests failed only due to the VM of Travis having a hiccup

@LefterisJP LefterisJP merged commit e68cac8 into rotki:develop Jul 11, 2020
@LefterisJP LefterisJP deleted the aave_fix_for_borrowing branch July 11, 2020 12:54
@LefterisJP LefterisJP mentioned this pull request Jul 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelsos kelsos kelsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LefterisJP @kelsos