Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zerion defi query #1150

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Conversation

LefterisJP
Copy link
Member

The aave specific fix introduced in #1137 is not needed. There was a mistake in the way we were interpreting the Zerion result.

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #1150 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1150   +/-   ##
========================================
  Coverage    73.35%   73.35%           
========================================
  Files          239      239           
  Lines        15261    15246   -15     
  Branches      2205     2201    -4     
========================================
- Hits         11195    11184   -11     
- Misses        3472     3475    +3     
+ Partials       594      587    -7     
Flag Coverage Δ
#backend 80.70% <100.00%> (+<0.01%) ⬆️
#frontend_unit 20.08% <ø> (ø)
Impacted Files Coverage Δ
rotkehlchen/chain/ethereum/aave.py 84.04% <ø> (+4.83%) ⬆️
rotkehlchen/chain/ethereum/zerion.py 88.09% <100.00%> (ø)
rotkehlchen/premium/premium.py 75.00% <0.00%> (-5.93%) ⬇️
rotkehlchen/externalapis/etherscan.py 73.83% <0.00%> (-1.17%) ⬇️
rotkehlchen/premium/sync.py 85.18% <0.00%> (-0.75%) ⬇️
rotkehlchen/inquirer.py 87.83% <0.00%> (-0.68%) ⬇️
rotkehlchen/externalapis/cryptocompare.py 60.18% <0.00%> (-0.32%) ⬇️
rotkehlchen/chain/manager.py 83.54% <0.00%> (-0.22%) ⬇️
rotkehlchen/exchanges/poloniex.py 76.60% <0.00%> (+0.29%) ⬆️
rotkehlchen/exchanges/bittrex.py 81.77% <0.00%> (+0.46%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e3abc...7c328e4. Read the comment docs.

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, so the problem was that due to indentation the append was missing it?

@LefterisJP
Copy link
Member Author

lgtm, so the problem was that due to indentation the append was missing it?

Pretty much yes. It was missing additional entries per protocol.

@LefterisJP
Copy link
Member Author

The MacOS test in github actions failed for irrelevant reason. merging.

@LefterisJP LefterisJP merged commit b200b78 into rotki:develop Jul 13, 2020
@LefterisJP LefterisJP deleted the fix_zerion_defi_query branch July 13, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants