Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle poloniex trade queries of more than 10k results #3048

Merged
merged 3 commits into from
Jun 4, 2021

Conversation

LefterisJP
Copy link
Member

Fix #81
Fix #3045

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #3048 (570856c) into bugfixes (3ff4d2e) will increase coverage by 0.85%.
The diff coverage is 61.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##           bugfixes    #3048      +/-   ##
============================================
+ Coverage     65.72%   66.57%   +0.85%     
============================================
  Files           522      561      +39     
  Lines         29990    36255    +6265     
  Branches       4261     5322    +1061     
============================================
+ Hits          19710    24136    +4426     
- Misses         9309    10809    +1500     
- Partials        971     1310     +339     
Flag Coverage Δ
backend 77.31% <82.36%> (-1.00%) ⬇️
frontend_integration 45.21% <46.59%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/app/src/background.ts 0.00% <0.00%> (ø)
...omponents/account-management/ConnectionLoading.vue 100.00% <ø> (ø)
...omponents/accounts/exchanges/ExchangeAmountRow.vue 0.00% <0.00%> (ø)
...components/accounts/exchanges/ExchangeBalances.vue 0.00% <0.00%> (ø)
...end/app/src/components/asset-manager/AssetForm.vue 0.00% <0.00%> (ø)
...p/src/components/asset-manager/AssetManagement.vue 0.00% <0.00%> (ø)
...nd/app/src/components/asset-manager/AssetTable.vue 0.00% <0.00%> (ø)
...d/app/src/components/asset-manager/MergeDialog.vue 0.00% <0.00%> (ø)
...ntend/app/src/components/assets/AssetLocations.vue 0.00% <ø> (ø)
...components/dashboard/BlockchainBalanceCardList.vue 8.33% <ø> (ø)
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2964f62...570856c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2021

This pull request fixes 1 alert when merging 570856c into 2964f62 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@LefterisJP
Copy link
Member Author

This pull request fixes 1 alert when merging 570856c into 2964f62 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

oh cool. Goes to show how old that code is. We get better LGTM score now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant