Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double counting xsushi #3423

Merged
merged 1 commit into from Sep 7, 2021
Merged

Conversation

yabirgb
Copy link
Member

@yabirgb yabirgb commented Sep 7, 2021

Closes #3407

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #3423 (7c1239a) into bugfixes (c7cd02a) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           bugfixes    #3423   +/-   ##
=========================================
  Coverage     66.22%   66.22%           
=========================================
  Files           605      605           
  Lines         39771    39771           
  Branches       6144     6144           
=========================================
  Hits          26339    26339           
+ Misses        11962    11960    -2     
- Partials       1470     1472    +2     
Flag Coverage Δ
frontend_integration 44.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rotkehlchen/chain/ethereum/tokens.py 92.04% <66.66%> (ø)
frontend/app/src/store/notifications/actions.ts 48.78% <0.00%> (-4.88%) ⬇️
frontend/app/src/services/task-manager.ts 83.01% <0.00%> (ø)
...c/components/status/notifications/Notification.vue 45.83% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb0b09...7c1239a. Read the comment docs.

Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you confirmed it works?

You also need to add a bugfix changelog entry.

@yabirgb
Copy link
Member Author

yabirgb commented Sep 7, 2021

@LefterisJP Yes It works. Didn't want to add an entry log because it will have merge conflicts with the other open PR ... Can do with the crypto.com fix

Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then LGTM. Do not forget to add the changelog in the other PR.

@LefterisJP LefterisJP merged commit 96144d9 into rotki:bugfixes Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants