Unsupported cex assets #3734
Merged
Unsupported cex assets #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we don't add a mapping to a specific asset thinking we have fixed the mapping but have also forgotten it in the unsupported assets list like we did in this issue: rotki#3702 (comment)
Codecov Report
@@ Coverage Diff @@
## master #3734 +/- ##
==========================================
- Coverage 64.91% 64.81% -0.11%
==========================================
Files 705 705
Lines 43814 43905 +91
Branches 6412 6413 +1
==========================================
+ Hits 28443 28455 +12
- Misses 13797 13891 +94
+ Partials 1574 1559 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3702 (again)
Add tests for all cexes comparing unsupported assets to mapping
This is so that we don't add a mapping to a specific asset thinking we
have fixed the mapping but have also forgotten it in the unsupported
assets list like we did in this issue:
RMRK for Kucoin and BCH for Bitfinex should now work properly again