Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rougify prints \e instead of corresponding character #1410

Closed
shoorick opened this issue Jan 24, 2020 · 5 comments
Closed

rougify prints \e instead of corresponding character #1410

shoorick opened this issue Jan 24, 2020 · 5 comments
Assignees
Labels
bugfix-request A request for a bugfix to be developed.

Comments

@shoorick
Copy link
Contributor

shoorick commented Jan 24, 2020

rougify prints wrong ANSI sequences: literally \e intead of special character ^[ (0x1b): all lines except first one begin with \e[38;5;230m and end with \e[39m

May be these sequences are unnecessary because colors are shown as expected.

To Reproduce

  1. Open terminal
  2. Execute path/to/rougify some-file.ext

Expected behavior

Expected output must not contain unnecessary characters.

Screenshot
wrong-ansi-sequences

System:

  • OS: Debian 10 Buster, GNOME Terminal 3.30.2
  • Ruby 2.5.5p157 (2019-03-15 revision 67260) [x86_64-linux-gnu]
  • Rouge 3.15.0
@shoorick shoorick added the bugfix-request A request for a bugfix to be developed. label Jan 24, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Jan 24, 2020

@shoorick I think this was fixed by #1402 and #1404. Could you test against the current master?

@pyrmont pyrmont self-assigned this Jan 24, 2020
@shoorick
Copy link
Contributor Author

I've tested again — it works, thank you.

rouge-no-error

@pyrmont
Copy link
Contributor

pyrmont commented Jan 24, 2020

@shoorick Great! All credit to @jneen; she came across this just before you did it would appear :D

We push out new versions of Rouge on a monthly cadence at the moment. The version with this fix (v3.16.0) is scheduled to go out on Tuesday 11 February.

@shoorick
Copy link
Contributor Author

@pyrmont Fine! I’m glad that Rouge is live and goes on.
I've made pull request for Gettext lexer and right now I'm working on LilyPond lexer (its syntax is more complicated than Gettext). I hope I’ll finish this work shortly.
rouge-lilypond-with-errors

@pyrmont
Copy link
Contributor

pyrmont commented Jan 25, 2020

@shoorick Yep, I've got that PR on my radar. Will try to get to it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix-request A request for a bugfix to be developed.
Projects
None yet
Development

No branches or pull requests

2 participants