Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin: Recognize destructuring assignment #1001

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Kotlin: Recognize destructuring assignment #1001

merged 1 commit into from
Oct 1, 2018

Conversation

lordcodes
Copy link
Contributor

Maps the destructured properties to Name.Property.

Fixes #885.

@lordcodes
Copy link
Contributor Author

CC @dblessing

@lordcodes
Copy link
Contributor Author

@jneen Sorry to bump this PR, but would be really keen to get these Kotlin PRs I have put forward included, as currently Rouge is almost unusable for Kotlin as it doesn't really highlight anything other than certain keywords.

Copy link
Collaborator

@dblessing dblessing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request, otherwise looks good. Thanks @lordcodes

spec/lexers/kotlin_spec.rb Outdated Show resolved Hide resolved
@lordcodes
Copy link
Contributor Author

@dblessing Test removed, thanks for the review.

@lordcodes
Copy link
Contributor Author

@dblessing This one is all done. Or do you want this squashed as well?

@lordcodes
Copy link
Contributor Author

Cleaned the branch up

@dblessing dblessing merged commit d4370ef into rouge-ruby:master Oct 1, 2018
@lordcodes lordcodes deleted the kotlin-destructuring branch October 1, 2018 18:41
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin: destructuring declaration not correctly highlighted
3 participants