Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TelegramEngine reaches recursion limit after a while #91

Closed
ElSaico opened this issue Oct 14, 2017 · 2 comments
Closed

TelegramEngine reaches recursion limit after a while #91

ElSaico opened this issue Oct 14, 2017 · 2 comments
Labels
bug

Comments

@ElSaico
Copy link
Contributor

ElSaico commented Oct 14, 2017 •
edited
Loading

With #79 solved, it seems a couple issues were unearthed.

After a while, since Python lacks tail-recursion due to a design decision by Guido himself, those consecutive calls to self.polling end up hitting the runtime's recursion depth limit, throwing a RecursionError in the process.

Of course, the bot becomes inoperant after this.
@rougeth
Copy link
Owner

rougeth commented Oct 15, 2017

Thanks @ElSaico! Any suggestion on how to solve this?

@rougeth rougeth added the bug label Oct 15, 2017
@bradshjg bradshjg mentioned this issue Oct 17, 2017
Closed
@rougeth
Copy link
Owner

rougeth commented Oct 17, 2017

Fixed here: https://github.com/rougeth/bottery/blob/master/bottery/platform/telegram.py#L114

@rougeth rougeth closed this as completed Oct 17, 2017
@jairojair jairojair mentioned this issue Oct 17, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElSaico @rougeth