Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline annotation renders incorrectly on small screens like iPhone 5/SE #11

Closed
pbamotra opened this issue May 28, 2020 · 4 comments
Closed

Comments

@pbamotra
Copy link

No description provided.

@pshihn
Copy link
Collaborator

pshihn commented May 29, 2020

What version of safari are you running? Perhaps share a screenshot?
Thanks!

@lucasverra
Copy link

It seems good to me, I just tested it
image

@pbamotra
Copy link
Author

pbamotra commented May 29, 2020

image

I changed the word on your website to "Computer vision" and also the circle in the bottom you can see. I tested it on Brave browser using the devtools.

Also, yeah maybe the JS didn't refresh because I made HTML edits (I'm sorry, I'm new to web programming). But, you can check with annotating two words that usually fall on the boundary of the screen, and the underlining doesn't behave as expected.

@fspoettel
Copy link

@pbamotra The plugin picks up changes to the viewport size via ResizeObserver and renders again in that case.

It cannot detect changes to the DOM made by inline HTML edits, hot reloading environments and changes via DOM attributes such as .textContent. In that case the annotation will not be redrawn automatically. You could trigger a redraw programatically via the .show()/.hide() methods.

@pshihn pshihn closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants