Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wired-tabs with nested wired-elements not working properly #99

Closed
abar193 opened this issue Apr 27, 2019 · 4 comments
Closed

wired-tabs with nested wired-elements not working properly #99

abar193 opened this issue Apr 27, 2019 · 4 comments
Assignees

Comments

@abar193
Copy link

abar193 commented Apr 27, 2019

if you put some wired-element (tested with button and tabs) inside of wired-tabs then any element, located not on initially active tab won't be rendered properly (e.g. buttons won't have their borders, e.t.c.)

An example here: https://codesandbox.io/s/48l9592k9x

@pshihn
Copy link
Contributor

pshihn commented Apr 27, 2019

Ah yeah. Some background around this:
Wired elements need to know their size to draw sketchy lines around them.
When not visible the size is not available.
As a work around you can call requestUpdate() method on the buttons when tab is visible.
I know this is not a viable workaround - will resolve this properly soon.

@pshihn pshihn self-assigned this Oct 14, 2019
@pshihn
Copy link
Contributor

pshihn commented Oct 14, 2019

Dev note: Perhaps add a trigger to parse down the tree to re-render

@constantine71
Copy link

constantine71 commented Nov 10, 2019

same issue when use them in my react app created by create-react-app
I was trying to put a wired-link inside a wired-card
then the wired-link would not show at all

@pshihn
Copy link
Contributor

pshihn commented Jun 20, 2020

resolved in 2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants